Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI REPL input validator to avoid running the JavaScript parser on REPL “dot commands”, preventing a syntax error from being displayed when using commands like .help.
Changes:
- Treat inputs starting with
.as valid in therustylinevalidator so dot commands don’t trigger JS parsing errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test262 conformance changes
Tested main commit: |
da21c36 to
4789150
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5231 +/- ##
===========================================
+ Coverage 47.24% 59.79% +12.55%
===========================================
Files 476 582 +106
Lines 46892 63462 +16570
===========================================
+ Hits 22154 37948 +15794
- Misses 24738 25514 +776 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit fixes the parsing error that shows when using `dot` commands in the REPL. It fixes this by preventing the passing of the `dot` commands to the JS parser.
4789150 to
be66525
Compare
This Pull Request fixes/closes #5219.
This commit fixes the parsing error that shows when using
dotcommands in the REPL.It fixes this by preventing the passing of the
dotcommands to the JS parser.It changes the following: