Skip to content

fix(repl): Dot commands not working.#5231

Open
gluzandii wants to merge 1 commit intoboa-dev:mainfrom
gluzandii:fix/dotcommand
Open

fix(repl): Dot commands not working.#5231
gluzandii wants to merge 1 commit intoboa-dev:mainfrom
gluzandii:fix/dotcommand

Conversation

@gluzandii
Copy link
Contributor

@gluzandii gluzandii commented Mar 22, 2026

This Pull Request fixes/closes #5219.

This commit fixes the parsing error that shows when using dot commands in the REPL.
It fixes this by preventing the passing of the dot commands to the JS parser.

It changes the following:

Copilot AI review requested due to automatic review settings March 22, 2026 19:09
@gluzandii gluzandii requested a review from a team as a code owner March 22, 2026 19:09
@github-actions github-actions bot added C-CLI Issues and PRs related to the Boa command line interface. Waiting On Review Waiting on reviews from the maintainers labels Mar 22, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI REPL input validator to avoid running the JavaScript parser on REPL “dot commands”, preventing a syntax error from being displayed when using commands like .help.

Changes:

  • Treat inputs starting with . as valid in the rustyline validator so dot commands don’t trigger JS parsing errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Mar 22, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,545 50,545 0
Ignored 1,426 1,426 0
Failed 992 992 0
Panics 2 2 0
Conformance 95.43% 95.43% 0.00%

Tested main commit: 66a1cd268ce6006918032b5d0f98d3a63c81b188
Tested PR commit: be66525a1cb0f031befd26e72e33c6a6b4cf3722
Compare commits: 66a1cd2...be66525

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.79%. Comparing base (6ddc2b4) to head (be66525).
⚠️ Report is 916 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/helper.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5231       +/-   ##
===========================================
+ Coverage   47.24%   59.79%   +12.55%     
===========================================
  Files         476      582      +106     
  Lines       46892    63462    +16570     
===========================================
+ Hits        22154    37948    +15794     
- Misses      24738    25514      +776     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This commit fixes the parsing error that shows when using `dot` commands in the REPL.

It fixes this by preventing the passing of the `dot` commands to the JS parser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-CLI Issues and PRs related to the Boa command line interface. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue in the dot commands of the REPL

3 participants