-
-
Notifications
You must be signed in to change notification settings - Fork 622
Fix docs spanned source text #5268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chaitanya-Parab
wants to merge
2
commits into
boa-dev:main
Choose a base branch
from
Chaitanya-Parab:fix-docs-spanned-source-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,7 +80,10 @@ impl SpannedSourceText { | |
| self.source_text.clone() | ||
| } | ||
|
|
||
| /// Test if the span is empty. | ||
| /// Returns `true` if the span or the source text is empty. | ||
| /// | ||
| /// # Returns | ||
| /// `true` if there is no span or the underlying source text is empty, otherwise `false`. | ||
|
Comment on lines
+83
to
+86
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the original comment is much more concise |
||
| #[inline] | ||
| #[must_use] | ||
| pub fn is_empty(&self) -> bool { | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
|
|
||
| ### Initial Idea Submission | ||
|
|
||
| * Full Name: Chaitanya Shivram Parab | ||
| * Email: [cparab02@gmail.com](mailto:cparab02@gmail.com) | ||
| * [Github](https://github.com/Chaitanya-Parab) | ||
| * [LinkedIn](https://www.linkedin.com/in/chaitanya-parab/) | ||
| * University name: Sindhudurg Shikshan Prasarak Mandal's College of Engineering, Kankavli | ||
| * Degree: Bachelor's of Engineering | ||
| * Major: Computer Science | ||
| * Year: 3rd year | ||
| * Expected graduation date: 2027 | ||
|
|
||
| Project Title: Public API Audit and Stabilization for Boa 1.0 | ||
| Relevant issues: (https://github.com/boa-dev/boa/issues/4524) | ||
|
|
||
|
|
||
| ### Idea description:### | ||
|
|
||
| Boa is approaching its 1.0 release, making API stability a critical requirement. Public APIs must be carefully reviewed to ensure they are consistent, well-documented and resilient to future changes without introducing breaking changes.My approach will focus on systematically auditing Boa’s public API surface and improving it to align with long-term stability goals. I plan to begin by identifying all publicly exposed items (pub structs, enums, traits and functions) across the codebase. Once identified, I will evaluate whether each item is intentionally public or should be restricted (e.g., converted to pub(crate) where appropriate). | ||
|
|
||
| A key part of the audit will involve: | ||
|
|
||
| 1. Replacing public struct fields with getter methods to prevent breaking changes in future modifications. | ||
|
|
||
| 2. Introducing #[non_exhaustive] where appropriate to allow extensibility of enums and structs. | ||
|
|
||
| 3. Ensuring consistent API design patterns across modules. | ||
|
|
||
| 4. Improving documentation for public-facing APIs to clearly define usage and guarantees. | ||
|
|
||
| I will take an incremental approach by working module-by-module, submitting small, focused pull requests to ensure reviewability and continuous progress.If time permits, I would also explore tooling or CI checks to detect unintended public API changes, helping maintain stability in the long term. | ||
|
|
||
| This project aligns closely with Boa’s goal of achieving a robust and stable 1.0 release, while also improving developer experience and maintainability. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not match with the actual function?