Skip to content

fix abortsignal event names#5269

Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom
Monti-27:abortsignal-events
Apr 10, 2026
Merged

fix abortsignal event names#5269
jedel1043 merged 2 commits intoboa-dev:mainfrom
Monti-27:abortsignal-events

Conversation

@Monti-27
Copy link
Copy Markdown
Contributor

Fixes #5260.

This makes AbortSignal.addEventListener ignore non abort event names instead of throwing.
It keeps the abort listener path the same and adds tests for ignored event names.

Tests:

  • cargo test -p boa_runtime abort --lib
  • cargo test -p boa_runtime --lib
  • cargo clippy -p boa_runtime --all-features --all-targets -- -D warnings

@Monti-27 Monti-27 requested a review from a team as a code owner March 27, 2026 14:43
@github-actions github-actions bot added the Waiting On Review Waiting on reviews from the maintainers label Mar 27, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 27, 2026
@github-actions github-actions bot added C-Tests Issues and PRs related to the tests. C-Runtime Issues and PRs related to Boa's runtime features labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,049 51,049 0
Ignored 1,482 1,482 0
Failed 594 594 0
Panics 0 0 0
Conformance 96.09% 96.09% 0.00%

Tested main commit: d6d76d86e9e18fca07f318f1db434cc8abffaf14
Tested PR commit: 72e45f22ea16a1471048625e13553cf40f984f64
Compare commits: d6d76d8...72e45f2

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.71%. Comparing base (6ddc2b4) to head (72e45f2).
⚠️ Report is 949 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5269       +/-   ##
===========================================
+ Coverage   47.24%   59.71%   +12.46%     
===========================================
  Files         476      589      +113     
  Lines       46892    63668    +16776     
===========================================
+ Hits        22154    38018    +15864     
- Misses      24738    25650      +912     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Monti-27 Monti-27 requested a review from jedel1043 April 10, 2026 13:28
Copy link
Copy Markdown
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@jedel1043 jedel1043 added the A-Bug Something isn't working label Apr 10, 2026
@jedel1043 jedel1043 added this pull request to the merge queue Apr 10, 2026
Merged via the queue into boa-dev:main with commit 248bbed Apr 10, 2026
22 checks passed
@github-actions github-actions bot removed the Waiting On Review Waiting on reviews from the maintainers label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Bug Something isn't working C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AbortSignal.addEventListener() throws on non-"abort" event names

2 participants