fix(object/ module/): convert remaining panics to EngineError::Panic#5311
fix(object/ module/): convert remaining panics to EngineError::Panic#5311KaustubhOG wants to merge 1 commit intoboa-dev:mainfrom
Conversation
|
@jedel1043 Following up on your review in #5063 regarding the Changing their return types from
does thiss idea looks fine ? |
Test262 conformance changes
Tested main commit: |
I was more thinking of a progressive migration to |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5311 +/- ##
===========================================
+ Coverage 47.24% 59.77% +12.52%
===========================================
Files 476 589 +113
Lines 46892 63690 +16798
===========================================
+ Hits 22154 38069 +15915
- Misses 24738 25621 +883 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ok. Will migrate call sites inside |
242be67 to
ab5705d
Compare
|
@jedel1043 Updated. Migrated all eligible Remaining |
Part of #3241. Follow-up to #5063 addressing review comment.
Changes:
operations.rs: converted 5 panics — ToObject, CreateDataPropertyOrThrow (js_expect), private_field_add, private_method_or_accessor_add, private_set (try_borrow_mut)internal_methods/mod.rs: migrated 6 borrow call sites to try_borrow/try_borrow_mutinternal_methods/string.rs: migrated 3 borrow call sites, return type of string_get_own_property changed to JsResult<Option>builtins/jsdataview.rs: migrated 2 borrow call sites to try_borrow