Repository navigation
test: add Sanic and Quart unit tests - #140
Merged
Merged
Conversation
Cover correlation id handling, request instrumentation, URL exclusion and app validation for the Sanic and Quart integrations using their test clients, instead of relying only on the smoke tests. Adds sanic-testing to the test requirements. Refs #137 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #137 (items 1 and 2).
Adds
tests/test_sanic.pyandtests/test_quart.pyusing each framework's in-process test client: correlation id from header / generated, request log content, excluded URL patterns, and rejecting a non-app object. Addssanic-testingtotest-requirements.txt(the Sanic test client lives there).Coverage: Sanic 39% -> 94%, Quart 64% -> 88%, total 80% -> 88%.
Tested: Python 3.14.6 on Windows (this branch is based on master alone), Sanic 25.12.1, Quart 0.23.1: 105 passed (unit suite excluding smoke tests and gunicorn). Not run on other Python versions in the CI matrix; Sanic's test client emits deprecation warnings on 3.14.