Repository navigation
refactor: Clean up compiler warnings, unused code and test idioms - #43
Merged
Merged
Conversation
Fix TextFilePropertiesDialog.createTitle() to use its fileName parameter, remove an unused field in FindToolBar, and tidy tests (getFirst(), stray semicolons, unused imports, simplified lambdas). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up minor code-quality issues: an unused field, a method ignoring its parameter, and assorted test-code nits.
Details
TextFilePropertiesDialog.createTitle(String)now uses itsfileNameparameter instead oftextArea.getFileName()infoLabelfield fromFindToolBarList.getFirst(), remove stray;;, unused import, a00literal, and a redundantStringBuilder/block lambdaTest plan
./gradlew clean buildpasses (checkstyle, spotbugs, tests)🤖 Generated with Claude Code