Repository navigation
ci: unbreak the GitHub Pages deploy workflow - #19
Merged
Merged
Conversation
`actions/upload-pages-artifact@v1` wraps `upload-artifact@v3`, which GitHub now fails automatically, so every deploy to Pages died before uploading. Bump the Pages actions and `actions/checkout` in both workflows to current majors. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every run of
Deploy static content to Pageshas been failing before it does any work:actions/upload-pages-artifact@v1wrapsactions/upload-artifact@v3, which GitHub now fails automatically, so the job died while resolving actions and the site was never republished.actions/configure-pages@v2andactions/deploy-pages@v1are equally stale.Changes
actions/upload-pages-artifactv1 -> v5actions/configure-pagesv2 -> v6actions/deploy-pagesv1 -> v5actions/checkoutv3 -> v7, in bothstatic.ymlandci.yml(v3 runs on the deprecated Node 16 runtime)Nothing else about the deploy changes: the published content is still the prebuilt
wasm/directory.Testing
Dispatching
static.ymlfrom this branch is rejected by thegithub-pagesenvironment protection rules before any step runs, so the deploy step itself can only be exercised frommain. To verify the part that was actually broken, a temporary workflow runningcheckout+configure-pages+upload-pages-artifactat the new versions was pushed to this branch. It succeeded, and the temporary workflow was removed again, so the net diff of this branch is only the two workflow updates.Made with Cursor