Open
Conversation
This changes the limit-options logic such that we trim lines from the end of the list we're dealing with. For example, if we know we are already going to render a top ellipsis, we should trim the preceding lines (top of the list) until we can fit on screen. Similarly, if we are rendering a bottom ellipsis, do the same for following lines. If there's currently no ellipsis, we trim the following lines, then the preceding lines. This particular part can be improved one day in a follow up. On top of this, correct wrapping has been added for the group multi-select prompt's options.
🦋 Changeset detectedLatest commit: 9843012 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the limit-options logic such that we trim lines from the
end of the list we're dealing with.
For example, if we know we are already going to render a top ellipsis,
we should trim the preceding lines (top of the list) until we can fit on
screen.
Similarly, if we are rendering a bottom ellipsis, do the same for
following lines.
If there's currently no ellipsis, we trim the following lines, then the
preceding lines. This particular part can be improved one day in a
follow up.
On top of this, correct wrapping has been added for the group
multi-select prompt's options.
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure