Skip to content

Potential proposal for 1384#1385

Open
ckormanyos wants to merge 2 commits intodevelopfrom
1384
Open

Potential proposal for 1384#1385
ckormanyos wants to merge 2 commits intodevelopfrom
1384

Conversation

@ckormanyos
Copy link
Copy Markdown
Member

@ckormanyos ckormanyos commented May 2, 2026

Here is a potential proposal to solve #1384. It uses fowrward declarations only.

I think it would still be wise to combine these forward declarations additionally with the consistent use of namespace-decorated log-functions in the internal headers of Decimal's cmath.

Cc: @mborland

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.6%. Comparing base (e995162) to head (f994f3a).

Files with missing lines Patch % Lines
test/github_issue_1384.cpp 87.5% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1385     +/-   ##
=========================================
- Coverage     98.6%   98.6%   -0.0%     
=========================================
  Files          285     286      +1     
  Lines        22698   22706      +8     
  Branches      1974    1975      +1     
=========================================
+ Hits         22365   22369      +4     
- Misses         333     337      +4     
Files with missing lines Coverage Δ
include/boost/decimal/cmath.hpp 100.0% <ø> (ø)
include/boost/decimal/detail/cmath/acosh.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/asinh.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/atanh.hpp 100.0% <100.0%> (ø)
...de/boost/decimal/detail/cmath/impl/ellint_impl.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/lgamma.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/log.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/log10.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/log1p.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/log2.hpp 100.0% <100.0%> (ø)
... and 4 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e995162...f994f3a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant