Potential proposal for 1384#1385
Open
ckormanyos wants to merge 2 commits intodevelopfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1385 +/- ##
=========================================
- Coverage 98.6% 98.6% -0.0%
=========================================
Files 285 286 +1
Lines 22698 22706 +8
Branches 1974 1975 +1
=========================================
+ Hits 22365 22369 +4
- Misses 333 337 +4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a potential proposal to solve #1384. It uses fowrward declarations only.
I think it would still be wise to combine these forward declarations additionally with the consistent use of namespace-decorated log-functions in the internal headers of Decimal's
cmath.Cc: @mborland