Skip to content

Fix cohort handling of zero to match IEEE 754 requirements#1389

Merged
mborland merged 14 commits into
developfrom
1387
May 6, 2026
Merged

Fix cohort handling of zero to match IEEE 754 requirements#1389
mborland merged 14 commits into
developfrom
1387

Conversation

@mborland
Copy link
Copy Markdown
Member

@mborland mborland commented May 6, 2026

Closes: #1387

@mborland mborland self-assigned this May 6, 2026
@mborland mborland added the Bug Something isn't working label May 6, 2026
@mborland
Copy link
Copy Markdown
Member Author

mborland commented May 6, 2026

These 32bit MSVC 14.5 failures are bizarre. It loses the sign and has stack overflows all over the place where the other MSVC versions have been green for a while. I'm going to move adding that runner to a different PR so that I can investigate what's going on better. These changes are still the correct ones.

@mborland mborland merged commit 697dbc7 into develop May 6, 2026
74 of 76 checks passed
@mborland mborland deleted the 1387 branch May 6, 2026 20:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 87.61905% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.5%. Comparing base (2b920bf) to head (54c3fb1).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/decimal128_t.hpp 66.7% 2 Missing ⚠️
include/boost/decimal/decimal32_t.hpp 66.7% 2 Missing ⚠️
include/boost/decimal/decimal_fast128_t.hpp 81.9% 2 Missing ⚠️
include/boost/decimal/decimal_fast32_t.hpp 81.9% 2 Missing ⚠️
...ude/boost/decimal/detail/remove_trailing_zeros.hpp 66.7% 2 Missing ⚠️
include/boost/decimal/decimal64_t.hpp 83.4% 1 Missing ⚠️
include/boost/decimal/decimal_fast64_t.hpp 91.0% 1 Missing ⚠️
include/boost/decimal/detail/parser.hpp 80.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1389     +/-   ##
=========================================
- Coverage     98.5%   98.5%   -0.0%     
=========================================
  Files          288     288             
  Lines        22749   22831     +82     
  Branches      1971    1985     +14     
=========================================
+ Hits         22402   22472     +70     
- Misses         347     359     +12     
Files with missing lines Coverage Δ
include/boost/decimal/charconv.hpp 95.9% <100.0%> (ø)
include/boost/decimal/detail/add_impl.hpp 94.0% <100.0%> (+0.7%) ⬆️
include/boost/decimal/detail/comparison.hpp 96.8% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/div_impl.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/quantize_impl.hpp 94.9% <ø> (+4.7%) ⬆️
test/github_issue_1383.cpp 100.0% <100.0%> (ø)
test/test_cmath.cpp 100.0% <100.0%> (ø)
test/test_erf.cpp 100.0% <100.0%> (ø)
test/test_to_chars.cpp 100.0% <100.0%> (ø)
include/boost/decimal/decimal64_t.hpp 94.6% <83.4%> (-0.1%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b920bf...54c3fb1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove canonicalization of 0

1 participant