tests: skip tz tests where time.tzset() is missing, not just on windows - #10279
Merged
ThomasWaldmann merged 1 commit intoAug 29, 2026
Merged
Conversation
haiku's python has no time.tzset either, so the local-timezone tests failed there (and their teardown errored). Skip on the actual reason rather than on the platform. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 87.48% 87.48% -0.01%
==========================================
Files 103 103
Lines 18534 18540 +6
Branches 2843 2844 +1
==========================================
+ Hits 16215 16219 +4
- Misses 1623 1624 +1
- Partials 696 697 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_match_bare_pattern_uses_local_timezonewas skipped based onis_win32, with "time.tzset() is not available on Windows" as the reason. Windows is not the only platform withouttime.tzset— haiku's python has none either, so the test failed there (AttributeError: module 'time' has no attribute 'tzset') and its teardown errored on the same call.Skip on the actual reason instead:
not hasattr(time, "tzset"). This covers Windows exactly as before, plus any other platform whose python lacks it. The now-unusedis_win32import goes away with it.Split out of the haiku CI work in #10249, since it is not haiku-specific.
🤖 Generated with Claude Code