Fix for Missing call to superclass __init__ during object initialization#9635
Merged
Conversation
ThomasWaldmann
force-pushed
the
finding-autofix-03f334da
branch
from
aec559f to
49e6b65
Compare
…ation Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ThomasWaldmann
force-pushed
the
finding-autofix-03f334da
branch
from
49e6b65 to
9d6a64e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this, update
TestDeriveKey.CustomKey.__init__to callKeyBase.__init__viasuper().__init__(None)before setting test-specific fields. This preserves existing test behavior while ensuring base initialization is not skipped.In
src/borg/testsuite/crypto/crypto_test.py, edit the nestedCustomKeyclass around lines 284–288:__init__, addsuper().__init__(None)as the first statement.self.crypt_keyandself.id_keyunchanged so test semantics remain identical.No new imports, methods, or external dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.