legacy: move upgrade.py into borg.legacy, refs #9556#9655
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9655 +/- ##
==========================================
- Coverage 83.08% 83.00% -0.09%
==========================================
Files 90 90
Lines 15653 15549 -104
Branches 2356 2340 -16
==========================================
- Hits 13006 12907 -99
Misses 1887 1887
+ Partials 760 755 -5 ☔ View full report in Codecov by Sentry. |
Member
|
UpgraderFrom12To20 - that is for borg 1.x (at that time it was 1.2, meanwhile it is 1.4). The NoOp upgrader is not legacy, it is used when transferring archives from borg2 -> borg2 repos. Not really an upgrade, rather moving stuff. |
mr-raj12
force-pushed
the
legacy-upgrade-phase5
branch
from
a3dacdc to
b0f3096
Compare
ThomasWaldmann
approved these changes
May 22, 2026
Member
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
LGTM (I assume you just moved the 12to20 code and you didn't change it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
UpgraderNoOpandUpgraderFrom12To20intoborg.legacy, refs #9556.src/borg/upgrade.py→src/borg/legacy/upgrade.py.Xto..Xtransfer_cmd.py:from .. import upgrade as upgrade_mod→from ..legacy import upgrade as upgrade_modNo logic changes. Both classes are Borg 1.x-only. Leaving them at the package root means an extra file to track down when v1 support is dropped; in
borg.legacyit goes away with the rest.Refs #9556
Checklist