Skip to content

defrag: add early permissions check #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasWaldmann merged 1 commit into from
Mar 28, 2026
+13 −0
Merged

defrag: add early permissions check #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/borgstore/backends/posixfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,19 @@ def _rename_to_new_name():
except FileNotFoundError:
raise ObjectNotFound(curr_name) from None

def defrag(self, sources, *, target=None, algorithm=None, namespace=None, levels=0) -> str:
if not self.opened:
raise BackendMustBeOpen()
# check all permissions before doing anything
prefix = namespace.rstrip("/") + "/" if namespace else ""
# if target is not given, an item named like content-hash is created in same namespace.
check_target = target if target else prefix + "01234567"
self._check_permission(check_target, "W")
names = [prefix + source[0] for source in sources]
for name in names:
self._check_permission(name, "r")
return super().defrag(sources, target=target, algorithm=algorithm, namespace=namespace, levels=levels)

def hash(self, name: str, algorithm: str = "sha256") -> str:
if not self.opened:
raise BackendMustBeOpen()
Expand Down
Loading