Skip to content

fix: save keep-within prune setting on text change (#2404)#2462

Open
williamcancodee wants to merge 1 commit intoborgbase:masterfrom
williamcancodee:fix-issue-2404
Open

fix: save keep-within prune setting on text change (#2404)#2462
williamcancodee wants to merge 1 commit intoborgbase:masterfrom
williamcancodee:fix-issue-2404

Conversation

@williamcancodee
Copy link
Copy Markdown

@williamcancodee williamcancodee commented Mar 19, 2026

Description

Changed the PyQt signal for the prune_keep_within text field in src/vorta/views/archive_tab.py from editingFinished to textChanged.

Related Issue

Closes #2404

Motivation and Context

Previously, the keep-within pruning option's configuration was stored to the profile model through the use of the editingFinished signal. However, this meant that if the user entered a value into the text box and then quit the application without dropping focus on the text box (i.e., without pressing enter or clicking elsewhere on the screen), the configuration was lost. By switching to the textChanged signal, we ensure that the model state is updated immediately after every keystroke, as is currently the case for the archive name templates.

How Has This Been Tested?

Manually tested in a local development environment (Windows / PyQt6):

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keep-within not remembered across sessions when vorta crashes or is forced to quit

1 participant