fix: save keep-within prune setting on text change (#2404)#2462
Open
williamcancodee wants to merge 1 commit intoborgbase:masterfrom
Open
fix: save keep-within prune setting on text change (#2404)#2462williamcancodee wants to merge 1 commit intoborgbase:masterfrom
williamcancodee wants to merge 1 commit intoborgbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the PyQt signal for the prune_keep_within text field in src/vorta/views/archive_tab.py from editingFinished to textChanged.
Related Issue
Closes #2404
Motivation and Context
Previously, the keep-within pruning option's configuration was stored to the profile model through the use of the editingFinished signal. However, this meant that if the user entered a value into the text box and then quit the application without dropping focus on the text box (i.e., without pressing enter or clicking elsewhere on the screen), the configuration was lost. By switching to the textChanged signal, we ensure that the model state is updated immediately after every keystroke, as is currently the case for the archive name templates.
How Has This Been Tested?
Manually tested in a local development environment (Windows / PyQt6):
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.