fix: guard darwin network test import behind platform check#2470
Open
Denay2468 wants to merge 3 commits intoborgbase:masterfrom
Open
fix: guard darwin network test import behind platform check#2470Denay2468 wants to merge 3 commits intoborgbase:masterfrom
Denay2468 wants to merge 3 commits intoborgbase:masterfrom
Conversation
Contributor
Author
|
All checks passing. Fixed CRLF -> LF line endings. Ready for review! |
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
uv run pytest tests/on Windows fails at collection time:pytestmarkskips test execution but cannot prevent the top-levelimport from running on Windows where CoreWLAN does not exist.
This crashes the entire test suite before any test runs.
Fix
Wrapped the import in
if sys.platform == 'darwin'so it neverexecutes on Windows or Linux.
Before / After
Before: ERROR collecting tests/network_manager/test_darwin.py
After: 11 darwin tests skip cleanly on Windows
Tested on