Skip to content

Fixing the Wifi connectivity issue when the wired connection is attached#2473

Open
Krishna-web-hub wants to merge 3 commits intoborgbase:masterfrom
Krishna-web-hub:Wifi_connectivity
Open

Fixing the Wifi connectivity issue when the wired connection is attached#2473
Krishna-web-hub wants to merge 3 commits intoborgbase:masterfrom
Krishna-web-hub:Wifi_connectivity

Conversation

@Krishna-web-hub
Copy link
Copy Markdown

@Krishna-web-hub Krishna-web-hub commented Mar 23, 2026

Description

  • Fixes WiFi detection when a wired (Ethernet) connection is primary. Previously, "get_current_wifi()" only checked the primary connection, causing WiFi SSID detection to fail when both Ethernet and WiFi were active.

  • This change updates the logic to iterate over all active NetworkManager connections and return the WiFi SSID if present.

Related Issue

Motivation and context

  • When both Ethernet and WiFi are connected , NetworkManager reports Ethernet as the primary connection. As a result, WiFi-based backup restrictions were not working because the WiFi SSID was never detected.

  • This change ensures that WiFi restrictions are respected even when Ethernet is the primary connection.

How Has This Been Tested?

  • Ran existing test suite ("pytest") - all tests passing
  • Verified behavior manually:
    • WiFi + Ethernet → WiFi correctly detected
    • Only Ethernet → no WiFi detected
    • Only WiFi → SSID correctly detected

Screenshots :

  • After fix:WhatsApp Image 2026-03-23 at 12 49 35 AM
  • Terminal output:WhatsApp Image 2026-03-23 at 12 49 35 AM(1)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the "CONTRIBUTING" (https://vorta.borgbase.com/contributing/) guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand WIFI check to all active networks.

1 participant