Repository navigation
Run new-commit samples and fix benchmark harness failures - #77
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner samples can now build an explicitly selected newer upstream commit while restoring the latest completed GitHub cache.
shais accepted only for samples and must identify a newer first-parent commit on the configured upstream branch. The build SHA and cache-source SHA remain separate, and rolling state is unchanged.The benchmark review also found two harness failures: pruning stopped when a listed cache had disappeared before DELETE, and Mastodon's plus Dockerfile omitted the
.ruby-versionfile now required by its Gemfile. Handle DELETE 404 without suppressing other errors, and copy the Ruby version before Bundler runs.Validation: 150 tests / 509 assertions passed for the sample and pruning changes; the additional Mastodon regression test passed.
bin/bench check,actionlint, Ruby syntax checks, andgit diff --checkpassed. PostHog and Zed samples on two newer commits each have been dispatched from this branch. Results remain Actions artifacts because branch runs do not publish records to main.