Use gpiozero active_high for inverted output#355
Open
cesaregiannetti wants to merge 5 commits into
Open
Conversation
Built-in active_high property of LED (and Output in general) handles the inverted output already, simplifying the access.
Collaborator
|
@cesaregiannetti , is it related to the #354 ? |
Author
Not really, I mentioned this PR in the issue because I saw the possibility while investigating the issue, but PR 355 does not fix issue 354. I don't know how to fix issue 354 in the right way, I don't know python and web, but I might find some time in the future to do so |
Author
|
@RobinTail I found a neat solution for #354, which is setting |
RobinTail
reviewed
Jun 21, 2025
relay state now reflects pin state. inversion is now managed by gpiozero.
|
coverage: 100.0%. remained the same — cesaregiannetti:active_high into borisbu:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in active_high property of LED (and Output in general) handles the inverted output already, simplifying the access.