Fix trailing whitespace and line-length in generated column annotations#10
Merged
Conversation
ColumnFormatter was emitting trailing spaces on column lines because the left-hand side was built with %-width padding and only stripped on the final joined line, not before passing through the wrapping branch. This produced: # trailing whitespace offense (padded left with no options) # line-too-long offense (continuation line included deep indent) Fix: rstrip left immediately after formatting, before any output path. indent_size is now derived from the stripped left length, keeping multiline default values visually aligned under their opening token.
boserh
force-pushed
the
fix/line-length-wrapping
branch
from
b98a80f to
ff79a43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColumnFormatter was emitting trailing spaces on column lines because the left-hand side was built with %-width padding and only stripped on the final joined line, not before passing through the wrapping branch. This produced:
trailing whitespace offense (padded left with no options)
line-too-long offense (continuation line included deep indent)
Fix: rstrip left immediately after formatting, before any output path. indent_size is now derived from the stripped left length, keeping multiline default values visually aligned under their opening token.