Conversation
EnumFormatter was returning one pre-joined multi-line string per enum
column (via lines.join("\n")). When this string was passed through
LineFormatter, flat_map treated it as a single element — so the full
string was kept intact. However the comma/no-comma logic used
labels.map.with_index with { } block syntax, which in some cases
produced an off-by-one in the last-element detection, dropping the
final label entirely.
Fix:
- Return a flat array of individual comment lines (flat_map + each_with_index)
consistent with every other formatter in the codebase
- Add AND t.typtype = 'e' to pg_enum_labels query to prevent joining
against a non-enum pg_type with the same name
- Update specs to assert on the flat line array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumFormatter was returning one pre-joined multi-line string per enum column (via lines.join("\n")). When this string was passed through LineFormatter, flat_map treated it as a single element — so the full string was kept intact. However the comma/no-comma logic used labels.map.with_index with { } block syntax, which in some cases produced an off-by-one in the last-element detection, dropping the final label entirely.
Fix: