Open
Conversation
The module now supports multiple agents and different languages for each one. It will now query an agent based on the locale of the user or the fallback language. The config has changed to handle multiple agents, as such API_TOKEN is now depreciated.
slvnperron
approved these changes
Oct 17, 2017
Member
slvnperron
left a comment
slvnperron
left a comment
There was a problem hiding this comment.
Thanks Oli for the awesome PR. The code looks good, we still have to test it internally on some existing bots to make sure it doesn't break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module now supports multiple agents and different languages for each one.
It will now query an agent based on the locale of the user or the fallback language.
The config has changed to handle multiple agents, as such API_TOKEN is now depreciated.
Calling getAvailableLang and getAgent for each query seems a bit redundant but I don't know if there is another way to do it with how things works currently, suggestions welcome ^^