fix(keeper): drop redundant kind from import-and-push request - #32
Merged
Conversation
The guest-room `call()` already carries the method name, and keeperd dispatches by method (its METHODS map), never by `params.kind`. The extra `kind: "import-and-push"` param was redundant and undeclared in the keeper-wire manifest. Drop it. Note on door-kit#21: the client's `ledgerRef` param is CORRECT and already conforms to keeper-wire v0.2.0 (which declares `ledgerRef` and computes `manifestDigest` daemon-side). The silent-data-drop bug the issue describes was on the daemon; fixed in door-keeper (compute manifestDigest from the box capability env). Only the `kind` cleanup applies here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial resolution of #21.
The guest-room
call()already carries the method name and keeperd dispatches by method (itsMETHODSmap), never byparams.kind. The extrakind: "import-and-push"was redundant and undeclared in the keeper-wire manifest. Dropped.The rest of #21 does not apply to this repo
The issue asked to rename the client's
ledgerRef→manifestDigest. That is stale/backwards vs the current keeper-wire v0.2.0 spec, which declaresledgerRefas a real param and computesmanifestDigestdaemon-side. This client already conforms — trellis's data-drivenkeeper-wireconformance check reads the manifest (which listsledgerRef) and passes.The actual silent-data-drop bug was on the daemon and is fixed in door-keeper#26 (compute
manifestDigestfrom the box capability env).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.