chore(beads): remove residual bd vestiges — dead spawns, machine stubs, Surface enum - #1025
Merged
Conversation
…s, Surface enum (GH-1022/1023/1024) Beads-removal follow-up cleanup: - GH-1022: remove the dead `prx beads update` subprocess back-write from fetch/gh-issues-writer (GitHub is the write plane; create-if-missing already establishes the ref); drop `"bd"` from `SYNC_MIRROR_DOMAINS`. - GH-1023: excise the triage XState machine's promote/drift-fix no-op stubs (`promoteActor`/`driftFixActor` + their types) and their `promoting`/ `driftDecision`/`driftFixing` states; re-point transitions through a `scopeDecision` pseudo-state (prime→done, else→reporting). - GH-1024 (partial): remove the last `"beads"` from the type system — the `Surface` enum, the `--from`/source-pin `WorkUnitSource` enum, spec/schema.cue `#Surface`, and the `kind = "github" | "notion"` help/error strings; drop the dead `--from=beads` create arm and convert its tests to notion. Verification: tsc clean · full suite 5556 pass / 0 fail · biome clean. Deferred (tracked on #1024): the inert `beads` actor / `beads_issue` / hydrateBeads no-op surface, and the Notion-integration removal decision (42 src files). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Beads-removal follow-up cleanup — the residual bd vestiges after #1021, filed as #1022/#1023/#1024.
prx beads <cmd>subprocess spawns left after #1021 #1022 — remove the deadprx beads updatesubprocess back-write infetch/gh-issues-writer.ts(GitHub is the write plane; create-if-missing already establishes the ref) + drop"bd"fromSYNC_MIRROR_DOMAINS.promoteActor/driftFixActorno-op stubs (+ their types) and thepromoting/driftDecision/driftFixingstates; re-point transitions through ascopeDecisionpseudo-state (prime→done, else→reporting)."beads"from the type system: theSurfaceenum (machine/effects.ts), the--from/source-pinWorkUnitSourceenum,spec/schema.cue#Surface, and thekind = "github" | "notion"help/error strings; drop the dead--from=beadscreate arm; convert its tests to notion.Verification
bunx tsc --noEmit→ cleanbiome check→ cleanDeferred (still tracked on #1024)
beadsactor /beads_issue/hydrateBeadsno-op surface (a separate actor/CLI surface).Closes #1022, closes #1023.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.