Merged
Conversation
Contributor
Author
|
Remaining failure is fixed by #3053 |
ZedThree
reviewed
Jan 7, 2025
tests/MMS/spatial/fci/runtest
Outdated
| mx, my = c.shape | ||
| kx = max(mx - 1, 1) | ||
| kx = min(kx, 3) | ||
| print(c.shape, kx) |
| xbwd = grid.read("backward_xt_prime")[1:-1] | ||
| try: | ||
| MXG = grid.read("MXG") | ||
| except: |
Member
There was a problem hiding this comment.
Should have explicit exception to catch
Contributor
Author
There was a problem hiding this comment.
Thanks for the review - all fixed!
ZedThree
previously approved these changes
Jan 7, 2025
bendudson
approved these changes
Jan 9, 2025
Contributor
bendudson
left a comment
bendudson
left a comment
There was a problem hiding this comment.
Thanks, @dschwoerer ! Happy new year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3050 and enables zoidberg based tests for more CI runs.
Also allow more recent versions. We probably always want the latest in CI, so that we can adopt if things break. Limiting that would only make sense if we know that there is a limitation and do not have time to adopt.