Open
Conversation
This was referenced Feb 24, 2026
Otherwise fmt tries to do compile-time checks, but fails as it cannot be checked at compile time. fmtlib/fmt#4179
With C++ std::accumulate uses std::move, which fails with the reference.
isatty is provided by both cpptrace and unistd.h, so we should only include one.
Mostly involves using `fmt::vformat` with `fmt::make_format_args` in functions/ctors that act like `fmt::format`. Note that `fmt::make_format_args` requires lvalues, so although we take `Args&&` we _must not_ call `std::forward`. We also have to introduce a new gettext macro `_f` to allow compile-time format arg checking _and_ runtime i18n substitution.
ZedThree
approved these changes
Feb 27, 2026
Member
ZedThree
left a comment
ZedThree
left a comment
There was a problem hiding this comment.
In a few years we can move to C++23 :)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| template <class... Args> | ||
| // NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward) | ||
| MsgStackItem(const std::string& file, int line, fmt::format_string<Args...> msg, | ||
| Args&&... args) |
Contributor
There was a problem hiding this comment.
warning: forwarding reference parameter 'args' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
Args&&... args)
^| mpi->MPI_Irecv(buffer, size, PVEC_REAL_MPI_TYPE, proc, tag, | ||
| BoutComm::get(), ch->request); | ||
| mpi->MPI_Irecv(buffer, size, PVEC_REAL_MPI_TYPE, proc, tag, BoutComm::get(), | ||
| ch->request); |
Contributor
There was a problem hiding this comment.
warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ch->request);
^| mpi->MPI_Irecv(buffer, size, PVEC_REAL_MPI_TYPE, proc, tag, | ||
| BoutComm::get(), ch->request); | ||
| mpi->MPI_Irecv(buffer, size, PVEC_REAL_MPI_TYPE, proc, tag, BoutComm::get(), | ||
| ch->request); |
Contributor
There was a problem hiding this comment.
warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ch->request);
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #3264
Mostly for testing and discussion.