Open
Conversation
Averages fields in Z. Smooth variation between 0 (no averaging) and 1 (full averaging). Intermediate values will retain some Z variation.
ZedThree
requested changes
Aug 4, 2025
Member
ZedThree
left a comment
ZedThree
left a comment
There was a problem hiding this comment.
LGTM, some small suggestions. Would be nice to get a test on it as well! :)
| def create( | ||
| averagelast=1, final=-1, path="data", output="./", informat="nc", outformat=None | ||
| averagelast=1, | ||
| averageZ=0.0, |
Member
There was a problem hiding this comment.
Default to None?
Suggested change
| averageZ=0.0, | |
| averageZ : None | float = None, |
| if outformat is None: | ||
| outformat = informat | ||
|
|
||
| averageZ = min([averageZ, 1.0]) |
Member
There was a problem hiding this comment.
Hard error if outside expected range?
Suggested change
| averageZ = min([averageZ, 1.0]) | |
| if not (0 < averageZ < 1.0): | |
| raise ValueError(f"`averageZ` (={averageZ}) must be in (0, 1)") |
| data[(final - averagelast) : final, :, :, :], axis=0 | ||
| ) | ||
|
|
||
| if averageZ > 0.0: |
Member
There was a problem hiding this comment.
Suggested change
| if averageZ > 0.0: | |
| if averageZ is not None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Averages fields in Z. Smooth variation between 0 (no averaging) and 1 (full averaging). Intermediate values will retain some Z variation.