Open
Conversation
Were already present in the non-orthogonal metric, but not the orthogonal case. Still remaining to check: - zShift, TwistShift - Curvature components
Because the direction of Z reverses when Bθ reverses, zShift also needs to be reversed.
flake8 upset by overly long line length
Collaborator
|
Possible alternative to this PR that might be simpler to implement: modify |
Contributor
Author
|
Hey @johnomotani That sounds like a good option to have, at least as an alternative to a negative-Jacobian coordinate system. Even having that capability would allow us to compare simulation results with and without a reversed (anticlockwise) grid to check that these coordinate system issues are handled correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking calculations for negative poloidal magnetic field (Jacobian < 0)
Following checking of the coordinate system in boutproject/BOUT-dev#2165
TODO