-
Notifications
You must be signed in to change notification settings - Fork 350
fix: support mid-migration metadata templates #4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JakubKida
wants to merge
15
commits into
master
Choose a base branch
from
metadata-namespace-migration-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b69d751
fix: support mid-migration metadata templates
JakubKida 9095cf1
fix(metadata-sidebar): fix mocks
JakubKida 8ed9663
fix(metadata-sidebar): Add dependency
JakubKida cf1e79e
fix(metadata-sidebar): Add to ignore patterns
JakubKida 7ca63a7
feat(metadata-sidebar): Add enterprise id hook ans tests
JakubKida eedefed
fix(metadata-sidebar): Fix flow issues
JakubKida e1ac3b4
fix(metadata-sidebar): Address improvements
JakubKida f232bab
feat(metadata-sidebar): Improve mode hook
JakubKida cb0fbec
feat(metadata-sidebar): compose hooks
JakubKida 8867d9a
feat(metadata-sidebar): Fix naming
JakubKida d8e8b8e
feat(metadata-editor): Fix flow types
JakubKida 36be471
feat(metadata-sidebar): Change todos
JakubKida 635a948
feat(metadata-sidebar): Adress comments
JakubKida f78533c
fix(metadata-sidebar): fix typing failures
JakubKida ceee4ee
fix(metadata-sidebar): Bump shared feature
JakubKida File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just calling out, other box-internal parent apps may need to add these as new deps which they may not be happy about. just something to look out for when developing shared features -> buie. i assume you're working on this same task though so it may be you doing that work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct — they come in via @box/metadata-template-editor. Parent apps that don’t already pull them will need to add them (same pattern as other BUIE peer deps). I’ll call that out in the parent-app bump PRs.