Repository navigation
chore(notifications): run the checker on the VPS; GitHub keeps a manual fallback - #1151
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The new-episode checker moves to the VPS and runs hourly; the GitHub workflow becomes a manual fallback that rehearses by default.
Motivation
The workflow is scheduled every 30 minutes, but GitHub ran it every 2–6 hours (for example 03:33, 09:08 and 14:25 UTC on 20 Oct), so notifications arrived hours late. Each run also committed its state file to the repository.
What changed
scripts/check-new-episodes.js: the state file path can be set withNOTIFIER_STATE_FILE; without it, nothing changes.workflow_dispatchstays as a fallback withdry_runon by default, because a live run there would use the repository's older state and resend releases.scripts/README.md: where the checker runs now and where its state lives.The VPS side (an hourly systemd timer, its own Firebase service account limited to reading registrations and sending pushes, state outside the checkout and in the daily backup) lives in the VPS repository.
Behavior & compatibility
Impact (required)
User impact — pick exactly one
user-impact-criticaluser-impact-highuser-impact-mediumuser-impact-lowno-user-impactBackend — optional, pairable with any user-impact level
backend-changeRelease copy (verbatim — highest priority)
CHANGELOG.md (required developer copy)
Changed
README What's New / Upcoming (required for user-impact changes)
Test plan
npm run test:check-new-episodes --prefix scripts: 45 tests pass.