Repository navigation
feat(sync): latest-episode tips carry the episode's served ID - #1152
Merged
Merged
Conversation
ashwkun
added
no-user-impact
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest-episode tip the catalog stores for each show (
latest_ep_id, used by Home, trending and bootstrap) now carries the episode's served ID, so old builds see one ID per episode everywhere.Motivation
Episode lists, single episodes, sync and notifications already use served IDs. Tips still stored Podcast Index's ID. For an episode Podcast Index renumbered (13 shows so far) or one first served from the live feed, Home could show it under a different ID than the rest of the app.
What changed
lib/episode-identity.jstipIdentity: the tip's served ID by catalog key, else Podcast Index's ID as an alias in the same show, else that ID (stage 4 records it with that ID later in the run).latest_ep_id, pluslatest_ep_keyandlatest_ep_eid(columns added with the episode book). A failed lookup keeps Podcast Index's ID and logs a warning. Change detection and the tip queue keep Podcast Index's own ID.lib/catalog-rows.jstipUpdateArgs: takes the identity; the key is always bound as text.Behavior & compatibility
Impact (required)
User impact — pick exactly one
user-impact-criticaluser-impact-highuser-impact-mediumuser-impact-lowno-user-impactBackend — optional, pairable with any user-impact level
backend-changeRelease copy (verbatim — highest priority)
CHANGELOG.md (required developer copy)
Changed
README What's New / Upcoming (required for user-impact changes)
Test plan
npm run test:sync --prefix scripts: 146 tests. 2 are new: the tip identity by key, by alias in the same show, else Podcast Index's ID; and the tip update binding the served ID with a text key.