Repository navigation
[CLOSED] FOR REVIEW: Update to jQuery 2.0.1, LESS 1.3.3 and Bootstrap 2.3.1 #3776
Description
Sunday Jun 02, 2013 at 01:29 GMT
Originally opened as adobe/brackets#4054
This pull requests updates jQuery to 2.0.1, LESS to 1.3.3 and Bootstrap to 2.3.1. This is a major update that has several breaking changes.
Major API changes are listed in the Sprint 26 release notes
Big thanks to@WebsiteDeveloper for the LESS and Bootstrap updates, and@TuckerWhitehouse for the jQuery update.
Remaining tasks:
- Fix ExtensionManager unit tests (20 failures)
- Fix FindReplace unit tests (14 failures)
- Fix Inline Color Editor unit tests (9 failures) (8 fixed, 1 remaining)
- Fix Url Code Hinting unit tests (2 failures)
gruehle included the following code: https://github.com/adobe/brackets/pull/4054/commits
Activity
core-ai-bot commentedon Aug 29, 2021
Monday Jun 03, 2013 at 14:01 GMT
When I run All of the extension tests, I see a failure in JavaScript Code Hinting that I don't see when I run the JS Code Hinting test on its own. Do you see that as well? I have a feeling that's independent of the work we're tracking here.
core-ai-bot commentedon Aug 29, 2021
Monday Jun 03, 2013 at 14:31 GMT
It turns out that the InlineColorEditor failure was actually a case of a jQuery change that required a fix in the code.
core-ai-bot commentedon Aug 29, 2021
Tuesday Jun 04, 2013 at 00:44 GMT
@njx - thanks for the review. Changes pushed, and ready for re-review.core-ai-bot commentedon Aug 29, 2021
Tuesday Jun 04, 2013 at 01:02 GMT
Review complete. The remaining issues I think we should consider addressing before landing the branch are:
$.support.transitionissue abovebrackets.inBrowserto true, the menus don't lay out properly and don't open when you click on them.There are a few other minor visual issues I'm seeing that I'll go ahead and file with [framework-update] in the subject.
core-ai-bot commentedon Aug 29, 2021
Tuesday Jun 04, 2013 at 01:11 GMT
Actually, I think we can land this before the in-browser menu work. I'll file a bug on that.
core-ai-bot commentedon Aug 29, 2021
Tuesday Jun 04, 2013 at 01:21 GMT
I added notes to the bottom of https://github.com/adobe/brackets/wiki/Research:-jQuery-2.0-Upgrade about the changes we made for jQuery 1.9.
@dangoor - do you think there's anything else in the 1.9 upgrade guide that's worth specifically warning people about (so they don't have to read all the various obscure things they probably won't care about)?core-ai-bot commentedon Aug 29, 2021
Tuesday Jun 04, 2013 at 01:21 GMT
Looks good aside from the filed bugs. Merging.