fix: game end condition not triggering when last player remains#1415
Merged
braedonsaunders merged 1 commit intomainfrom Feb 10, 2026
Merged
fix: game end condition not triggering when last player remains#1415braedonsaunders merged 1 commit intomainfrom
braedonsaunders merged 1 commit intomainfrom
Conversation
Two bugs prevented the game from ending when only one player survived: 1. Victory condition used entity queries to count players, but buildings are immediately destroyed on death. If eliminated players had no surviving units, they disappeared from entity queries, causing players.size to be 1 and preventing victory from ever being declared. Fixed by using the stable playerTeams map from game setup instead. 2. AICoordinator continued running combat tactics for eliminated AI players (zero buildings path), causing their surviving units to actively fight and potentially kill the remaining player. Fixed by tracking eliminated players via game:playerEliminated events and skipping their updates entirely. Also fixed handleSurrender to exclude already-eliminated players when determining the winner. https://claude.ai/code/session_01AXNWK1n2KziPhLXqMJqX8Q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs prevented the game from ending when only one player survived:
Victory condition used entity queries to count players, but buildings are immediately destroyed on death. If eliminated players had no surviving units, they disappeared from entity queries, causing players.size to be 1 and preventing victory from ever being declared. Fixed by using the stable playerTeams map from game setup instead.
AICoordinator continued running combat tactics for eliminated AI players (zero buildings path), causing their surviving units to actively fight and potentially kill the remaining player. Fixed by tracking eliminated players via game:playerEliminated events and skipping their updates entirely.
Also fixed handleSurrender to exclude already-eliminated players when determining the winner.
https://claude.ai/code/session_01AXNWK1n2KziPhLXqMJqX8Q