feat(release-notes): dry-run#20
Closed
adrmachado-public wants to merge 2 commits into
Closed
Conversation
adrmachado-public
marked this pull request as ready for review
June 5, 2026 20:48
GoogilyBoogily
requested changes
Jun 8, 2026
GoogilyBoogily
left a comment
GoogilyBoogily
left a comment
Contributor
There was a problem hiding this comment.
One small thing, and it's a my b
Comment on lines
+21
to
+24
| - name: "Setup Node.js" | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: .nvmrc |
Contributor
There was a problem hiding this comment.
I know this was a me thing, but we should swap to use our own custom setup-node action
Contributor
Author
There was a problem hiding this comment.
this was missed in a lot of files, so the pr has gotten a lil thicker
Contributor
Author
|
ok genuinely no idea what happened but when i tried to use jujutsu to move the bookmark forward it?? removed the forward slash??? i opened up a new PR #21 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to
actions/release-notes/action.yml:actions/setup-node@v6step — the action previously assumed Node.js was already set up by a prior action in the same job, creating a fragile implicit dependencynode dist/extract-release-notes.js(from the feat/git-utils PR)dry-runboolean input torelease-pipeline, and thread it toversion-bump,npm-publish, andrelease-notestweaks: