Skip to content

fix: cut releases from the release branch instead of blocking on PR merge#25

Merged
GoogilyBoogily merged 3 commits into
mainfrom
fix/cut-releases-from-release-branch
Jul 10, 2026
Merged

fix: cut releases from the release branch instead of blocking on PR merge#25
GoogilyBoogily merged 3 commits into
mainfrom
fix/cut-releases-from-release-branch

Conversation

@GoogilyBoogily

@GoogilyBoogily GoogilyBoogily commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

The release pipeline opened a PR into the base branch and then blocked polling for its own merge. But the base branch requires human review that auto-merge can't bypass, so the wait always timed out and no release ever completed. This cuts the release from the long-lived release branch instead, so deploy no longer waits on the base-branch review gate.

Changes

  • version-bump: check out release, merge the base branch in, then bump version + CHANGELOG
  • release-pr: push release, tag vX.Y.Z on it, open a non-blocking release -> base sync PR (auto-merge once reviewed). Dropped the merge-wait poll and the post-merge tail.
  • release-pipeline: publish from that tag by reusing publish.yml
  • release-notes: honor the checked-out ref (removed the hardcoded git checkout main); create the GitHub release at the v-prefixed tag
  • stale-cleanup: exempt the release branch so it isn't deleted between releases

Follow-up (not in this PR)

Bump the internal action refs (currently @cf4b40f...) to this commit's SHA so release-pipeline -> publish.yml -> release-notes all resolve to the fixed code, then re-pin the consumer repos.

…erge

The release flow opened a PR into the base branch and then blocked polling
for its own merge. But the base branch requires human review that auto-merge
can't bypass, so the wait always timed out and no release ever completed.

Cut the release from the long-lived release branch instead:
- version-bump checks out release, merges the base branch in, then bumps
- release-pr pushes release, tags vX.Y.Z on it, and opens a non-blocking
  sync PR back to base (auto-merge once it's reviewed)
- release-pipeline publishes from that tag by reusing publish.yml
- release-notes honors the checked-out ref (dropped the hardcoded checkout
  main) and creates the GitHub release at the v-prefixed tag
- stale-cleanup exempts the release branch so it isn't deleted between releases

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release automation so releases are cut from a long-lived release branch (and published from a vX.Y.Z tag) rather than blocking on a release PR merging into the protected base branch.

Changes:

  • Adjusts the version bump flow to merge BASE_BRANCH into release before bumping and then pushes release, tags vX.Y.Z, and opens a non-blocking sync PR back into base.
  • Updates release notes creation to use the currently checked-out ref and to create GitHub releases at v-prefixed tags.
  • Refactors the release pipeline to publish via the reusable publish.yml workflow using the created vX.Y.Z tag, and exempts release from stale-branch cleanup.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/release-pr.ts Switches release PR creation to a release -> base sync PR and tags/pushes vX.Y.Z from release (no merge-wait polling).
actions/version-bump/action.yml Checks out/creates the release branch, merges base into it, then bumps version and runs the updated release PR/tagging step.
actions/release-notes/action.yml Removes hardcoded main checkout behavior and creates GitHub releases at vX.Y.Z tags.
.github/workflows/stale-cleanup.yml Prevents the long-lived release branch from being deleted by stale cleanup.
.github/workflows/release-pipeline.yml Publishes from the vX.Y.Z tag via reusable publish.yml instead of publishing from the workflow’s triggering SHA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/release-pr.ts
Comment thread src/release-pr.ts

@codentacos codentacos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@GoogilyBoogily
GoogilyBoogily merged commit 2e28547 into main Jul 10, 2026
1 check passed
@GoogilyBoogily
GoogilyBoogily deleted the fix/cut-releases-from-release-branch branch July 10, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants