Improve parameter flexibility#160
Merged
Merged
Conversation
Stephen Belanger (Qard)
requested review from
Ankur Goyal (ankrgyl) and
Olmo Maldonado (ibolmo)
Stephen Belanger (Qard)
added
enhancement
Braintrust eval reportAutoevals (parameter-flexibility-1768263664)
|
Braintrust eval reportAutoevals (parameter-flexibility-1768258553)
|
Olmo Maldonado (ibolmo)
approved these changes
Jan 13, 2026
Olmo Maldonado (ibolmo)
left a comment
Olmo Maldonado (ibolmo)
left a comment
Collaborator
There was a problem hiding this comment.
Quick tests would be good, but looks reasonable.
This makes max_tokens configurable and makes both it and temperature fallback to model-provided defaults otherwise.
Stephen Belanger (Qard)
force-pushed
the
parameter-flexibility
branch
from
89c7134 to
19fceba
Compare
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes max_tokens configurable and makes both it and temperature fallback to model-provided defaults otherwise.
Fixes #149