squash BrainstoreTrace LLM convo bug#124
Merged
Merged
Conversation
brainstore trace llm convo required a root span for DFS traversal. This didn't work inside of trace scorers because the root span of an eval is not reported until after scoring completes. This change updates the logic to run convo dfs over forest roots in addition to the real root
Andrew Kent (realark)
force-pushed
the
ark/llm-convo-fix
branch
from
cf2efed to
49d1fcc
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brainstore trace llm convo required a root span for DFS traversal. This didn't work inside of trace scorers because the root span of an eval is not reported until after scoring completes.
This change updates the logic to run convo dfs over forest roots in addition to the real root