Skip to content

fix: DatasetCase.metadata() always empty when fetching dataset rows from Braintrust #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Kent (realark) merged 1 commit into from
Jun 18, 2026
Merged

fix: DatasetCase.metadata() always empty when fetching dataset rows from Braintrust #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions braintrust-sdk/src/main/java/dev/braintrust/eval/DatasetBrainstoreImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,18 @@ public Optional<DatasetCase<INPUT, OUTPUT>> next() {
OUTPUT expected = (OUTPUT) event.getExpected();

var metadataObj = event.getMetadata();
Map<String, Object> metadata =
metadataObj != null ? metadataObj.getAdditionalProperties() : Map.of();
if (metadata == null) metadata = Map.of();
// InsertProjectLogsEventMetadata extends HashMap<String,Object>. Jackson stores
// unknown fields in the HashMap base (not in additionalProperties) for Map subclasses,
// so copy from both sources defensively.
Map<String, Object> metadata;
if (metadataObj != null) {
metadata = new HashMap<>(metadataObj);
if (metadataObj.getAdditionalProperties() != null) {
metadata.putAll(metadataObj.getAdditionalProperties());
}
} else {
metadata = Map.of();
}

List<String> tags = event.getTags() != null ? event.getTags() : List.of();

Expand Down
44 changes: 44 additions & 0 deletions braintrust-sdk/src/test/java/dev/braintrust/eval/DatasetBrainstoreImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,50 @@ void testFetchWithPinnedVersion() {
.withRequestBody(matchingJsonPath("$.version", equalTo(pinnedVersion))));
}

@Test
void testMetadataPopulatedFromDatasetRow() {
wireMock.stubFor(
post(urlEqualTo("/v1/dataset/" + datasetId + "/fetch"))
.willReturn(
aResponse()
.withStatus(200)
.withHeader("Content-Type", "application/json")
.withBody(
"""
{
"events": [
{
"object_type": "dataset",
"dataset_id": "%s",
"id": "meta-row-1",
"_xact_id": "1",
"created": "2024-01-01T00:00:00Z",
"input": "test input",
"expected": "test output",
"metadata": {
"performance_strategy": "TURBO",
"userId": "user123"
}
}
],
"cursor": null
}
"""
.formatted(datasetId))));

DatasetBrainstoreImpl<String, String> dataset =
new DatasetBrainstoreImpl<>(apiClient, datasetId, "test-version");

List<DatasetCase<String, String>> cases = new ArrayList<>();
dataset.forEach(cases::add);

assertEquals(1, cases.size());
Map<String, Object> metadata = cases.get(0).metadata();
assertFalse(metadata.isEmpty(), "metadata should not be empty");
assertEquals("TURBO", metadata.get("performance_strategy"));
assertEquals("user123", metadata.get("userId"));
}

@Test
void testFetchFromBraintrustNotFound() {
String projectName = "test-project";
Expand Down
Loading