Fix dataset-backed eval origin for copied dataset rows#2140
Merged
ekeith (evanmkeith) merged 6 commits intoJun 18, 2026
Conversation
## Summary Fix dataset-backed eval/playground origin handling so copied dataset rows use the active dataset row id instead of preserved source provenance. ## Details Dataset rows copied from logs can carry origin pointing at the original project_logs row. runEvaluator previously preferred that datum.origin over the synthesized dataset-row origin, causing playground output/progress events to be keyed by the source log row id instead of the selected dataset row id. This changes dataset-backed evals to prefer the active dataset row origin whenever eventDataset and datum.id are present. Inline/non-dataset evals still preserve explicit datum.origin. ## Tests - Added regression coverage for log-derived dataset rows using dataset row origin - Added coverage for dataset rows without _xact_id - Added coverage for streamed progress events carrying dataset row origin - Ran focused Vitest origin tests successfully via local Vitest binary
max-braintrust
approved these changes
Jun 18, 2026
Contributor
|
updated the code a little bit. Feel free to merge after tests. Thanks again ekeith (@evanmkeith)! |
Contributor
|
Thanks for catching+fixing this! Added the changeset so it will pass - lmk if I can help FI. |
Contributor
Author
|
Thank you both!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix dataset-backed eval/playground origin handling so copied dataset rows use the active dataset row id instead of
preserved source provenance.
Details
Dataset rows copied from logs can carry origin pointing at the original project_logs row. runEvaluator previously
preferred that datum.origin over the synthesized dataset-row origin, causing playground output/progress events to be
keyed by the source log row id instead of the selected dataset row id.
This changes dataset-backed evals to prefer the active dataset row origin whenever eventDataset and datum.id are
present. Inline/non-dataset evals still preserve explicit datum.origin.
Tests