chore(ci): use real bt in ci, not a mock up - #97
Merged
Conversation
Cedric / ViaDézo1er (viadezo1er)
marked this pull request as ready for review
August 26, 2026 21:59
| await new Promise<void>((resolve, reject) => | ||
| server.close((error) => (error ? reject(error) : resolve())), | ||
| ); | ||
| await rm(home, { recursive: true, force: true }); |
There was a problem hiding this comment.
this is a bit scary to run. Can we just make this all work w/ tmp directories?
Contributor
Author
There was a problem hiding this comment.
packages/spark/test/braintrust-cli.test.ts:21:
const home = await mkdtemp(join(tmpdir(), "braintrust-cli-test-"));
home is a temp dir.
Contributor
Author
There was a problem hiding this comment.
But maybe I should rename home?
There was a problem hiding this comment.
it's not a big deal, I just didn't read this properly. we are good.
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/use-real-bt-in-ci
branch
from
August 26, 2026 22:30
95b59b1 to
213f610
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Aug 27, 2026
Cedric / ViaDézo1er (viadezo1er)
merged commit Aug 27, 2026
7febf37
into
main
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fails because BRAINTRUST_SERVICE_TOKEN repository secret has been added but CI on main doesn't export it yet.