Show the cause of an exception in bref logs - #54
Merged
Merged
Conversation
Without --full, an exception showed only its class and location, for example "RuntimeException at app/Billing.php:37". The actual cause, for example the HTTP error behind it, needed --full and the stack traces. Each previous exception now shows on a "Caused by Class: message" line. Bref Cloud sends the previous exceptions without --full from the next deployment. With an earlier Bref Cloud, the output does not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
--full,bref logsshows only the class and the location of an exception. To see the actual cause, for example the HTTP error behind aRuntimeException, the user must use--fulland read the stack traces.This change shows each previous exception on a "Caused by" line:
Bref Cloud sends the previous exceptions without
--fullafter https://github.com/brefphp/cloud/pull/386. With an earlier Bref Cloud, the output does not change.