Conversation
8f06d5f to
acc2ff8
Compare
acc2ff8 to
39ff195
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 14.77% 15.63% +0.85%
==========================================
Files 127 130 +3
Lines 16977 17273 +296
==========================================
+ Hits 2508 2700 +192
- Misses 14182 14263 +81
- Partials 287 310 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80b7284 to
848737d
Compare
| if err := cmd.Run(); err != nil { | ||
| return fmt.Errorf("sudo tee %s failed: %w", path, err) | ||
| } | ||
| if err := exec.Command("sudo", "chmod", "644", path).Run(); err != nil { //nolint:gosec // fixed base path |
There was a problem hiding this comment.
Its best practice for us to not run sudo our selves but ask the user to run the command with sudo and elevate permisions. Can we make this change?
There was a problem hiding this comment.
we run sudo commands in a few other places as well without asking the user (open and write-connection-event in particular).
I can do this in a follow up, and move the register and deregister commands to check if current user is sudo and prompt for password instead.
There was a problem hiding this comment.
polish: name sanitization, interfaces email caching, etc