Conversation
johnl
force-pushed
the
32962-support-k3s
branch
2 times, most recently
from
5cd3688 to
0db3f80
Compare
previously we only stripped the brightbox:// prefix but would then go on to try use any other providerIDs with the api. So instead, strip all provider prefixes and trust the Brightbox API to be the authority on what is a brightbox server and what is not. This fixes using the provider with k3s, which uses a k3s:// provider prefix, but should also work for future prefixes.
johnl
force-pushed
the
32962-support-k3s
branch
2 times, most recently
from
fb49ea2 to
3d58113
Compare
johnl
force-pushed
the
32962-support-k3s
branch
from
3d58113 to
7c087e9
Compare
johnl
force-pushed
the
32962-support-k3s
branch
from
7c087e9 to
ef25e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously we only stripped the brightbox:// prefix but would then go on to try
use any other providerIDs with the api. So instead, strip all provider prefixes
and trust the Brightbox API to be the authority on what is a brightbox server
and what is not.
This fixes using the provider with k3s, which uses a k3s:// provider prefix, but
should also work for future prefixes.