fix: transparent hole being shown before video starts OS-20428#143
Open
t-bashir-bs wants to merge 1 commit into
Open
fix: transparent hole being shown before video starts OS-20428#143t-bashir-bs wants to merge 1 commit into
t-bashir-bs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
CRI reported that when a video is started with hwz z-index 1 a flash can be seen before the video starts. This was only happening with CR120. What is happening is that when the video is started, but before any frames are shown the area covered by the video element is transparent. The flash is from the (usually black) background behind the html window. With z-index 1 we should just see the canvas behind the video element. The issue is easy to see if a hack is made to the mpv video opacity is set to 0, but the video element opacity is left as 100%. Without this hack you only see a flash. I did try to modify a Carson test to verify and check this scenario by using a transparent video, but we don't seem to play those correctly.
I did verify the changed hadn't broken any of the other html video Carson tests.
Checklist
npm testpassesRelease Notes
Notes: