Conversation
…d YAML linting workflow to GitHub Actions
WalkthroughAdds a YAML lint job to CI, reformats a Dependabot workflow file, tweaks Dockerfile PHP extensions, adjusts docker-publish workflow formatting, and extends hadolint ignored rules. No functional runtime logic changes beyond the new YAML lint job. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @.github/workflows/code-lint.yml:
- Around line 40-48: Disable the yamllint document-start rule in the embedded
config_data so yamllint stops requiring leading `---`; update the rules block
(in the config_data section of the code-lint workflow) to include the
'document-start' rule set to 'disable' (alongside existing rules like
'comments', 'line-length', and 'truthy') so the workflow no longer reports
warnings for files that omit the YAML document start.
In @.github/workflows/dependabot.yml:
- Around line 27-31: Add a final newline character to the end of the GitHub
Actions workflow file so it passes yamllint; open the file containing the
"Enable auto-merge for Dependabot PRs" job (the block with name: Enable
auto-merge for Dependabot PRs and the env variables PR_URL and GH_TOKEN) and
ensure there is a trailing newline at the end of the file (save the file so the
final byte is a newline).
- Around line 14-15: The workflow uses a custom runner label runs-on:
brixion-runners which actionlint will reject unless whitelisted; update your
actionlint configuration to permit this label (add "brixion-runners" to the
allowed runners list or enable/allow self-hosted runners in the actionlint
config), or alternatively adjust the workflow to use an allowed runner label;
reference the runs-on: brixion-runners entry to locate the affected job and
ensure the actionlint config key (allowed_runners / allow-self-hosted) is
updated accordingly.
🧹 Nitpick comments (1)
Dockerfile (1)
20-31: Avoid double‑installingpdo_pgsql.
pdo_pgsqlis already installed viadocker-php-ext-installabove, so listing it again ininstall-php-extensionsis redundant and can increase build time or cause conflicts. Pick one mechanism.♻️ Suggested minimal fix (remove duplicate)
install-php-extensions \ `@composer` \ pdo_mysql \ - pdo_pgsql \ apcu \ gd \ intl \
🔍 Samenvatting
Deze PR voegt extenties toe, en lost een paar kleine problemen op
✅ Checklist