Skip to content

🐳 Update Dockerfile to include pdo_mysql and pdo_pgsql extensions; add YAML linting workflow to GitHub Actions#12

Merged
LegeBeker merged 2 commits intomainfrom
fix/small-issues
Jan 29, 2026
Merged

🐳 Update Dockerfile to include pdo_mysql and pdo_pgsql extensions; add YAML linting workflow to GitHub Actions#12
LegeBeker merged 2 commits intomainfrom
fix/small-issues

Conversation

@LegeBeker
Copy link
Copy Markdown
Member

🔍 Samenvatting

Deze PR voegt extenties toe, en lost een paar kleine problemen op

✅ Checklist

  • Code is lokaal getest
  • Tests zijn toegevoegd/aangepast
  • Documentatie bijgewerkt (indien nodig)

@LegeBeker LegeBeker self-assigned this Jan 29, 2026
@LegeBeker LegeBeker added the type: 👷 ci GitHub Actions implementation label Jan 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026

Walkthrough

Adds a YAML lint job to CI, reformats a Dependabot workflow file, tweaks Dockerfile PHP extensions, adjusts docker-publish workflow formatting, and extends hadolint ignored rules. No functional runtime logic changes beyond the new YAML lint job.

Changes

Cohort / File(s) Summary
CI: Linting workflow
.github/workflows/code-lint.yml
Adds a new "YAML Lint" job using ibiqlik/action-yamllint@v3 (strict mode), sets fetch-depth: 2, 5-minute timeout, and a config_data block enforcing rules including 100-char line length and spacing/truthy settings.
CI: Workflow formatting
.github/workflows/dependabot.yml
Reformatted top-level YAML indentation/alignment only; no logic or behavior changes.
CI: Docker publish formatting
.github/workflows/docker-publish.yml
Rewrote a docker save step to use a multi-line shell invocation and changed some artifact/output strings to YAML folded style (>-) without altering content.
Container image config
Dockerfile
Added pdo_mysql and pdo_pgsql to PHP extensions install list; removed duplicate intl entry.
Lint rules config
.hadolint.yaml
Added --- YAML document start and expanded ignored list with DL3018, DL3013, and DL3016 to suppress certain version-pinning warnings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main changes: adding PHP extensions to Dockerfile and adding YAML linting workflow to GitHub Actions.
Description check ✅ Passed The description mentions adding extensions and resolving small issues, which relates to the changeset. However, the description is in Dutch and uses non-technical language.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In @.github/workflows/code-lint.yml:
- Around line 40-48: Disable the yamllint document-start rule in the embedded
config_data so yamllint stops requiring leading `---`; update the rules block
(in the config_data section of the code-lint workflow) to include the
'document-start' rule set to 'disable' (alongside existing rules like
'comments', 'line-length', and 'truthy') so the workflow no longer reports
warnings for files that omit the YAML document start.

In @.github/workflows/dependabot.yml:
- Around line 27-31: Add a final newline character to the end of the GitHub
Actions workflow file so it passes yamllint; open the file containing the
"Enable auto-merge for Dependabot PRs" job (the block with name: Enable
auto-merge for Dependabot PRs and the env variables PR_URL and GH_TOKEN) and
ensure there is a trailing newline at the end of the file (save the file so the
final byte is a newline).
- Around line 14-15: The workflow uses a custom runner label runs-on:
brixion-runners which actionlint will reject unless whitelisted; update your
actionlint configuration to permit this label (add "brixion-runners" to the
allowed runners list or enable/allow self-hosted runners in the actionlint
config), or alternatively adjust the workflow to use an allowed runner label;
reference the runs-on: brixion-runners entry to locate the affected job and
ensure the actionlint config key (allowed_runners / allow-self-hosted) is
updated accordingly.
🧹 Nitpick comments (1)
Dockerfile (1)

20-31: Avoid double‑installing pdo_pgsql.

pdo_pgsql is already installed via docker-php-ext-install above, so listing it again in install-php-extensions is redundant and can increase build time or cause conflicts. Pick one mechanism.

♻️ Suggested minimal fix (remove duplicate)
     install-php-extensions \
     `@composer` \
     pdo_mysql \
-    pdo_pgsql \
     apcu \
     gd \
     intl \

Comment thread .github/workflows/code-lint.yml
Comment thread .github/workflows/dependabot.yml
Comment thread .github/workflows/dependabot.yml Outdated
@LegeBeker LegeBeker merged commit 7ca1cf4 into main Jan 29, 2026
9 checks passed
@LegeBeker LegeBeker deleted the fix/small-issues branch January 29, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: 👷 ci GitHub Actions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant