Skip to content

🐳 Add GitHub CLI to Dockerfile#4

Merged
rickyheijnen merged 1 commit intomainfrom
feat/add-gh-cli
Aug 15, 2025
Merged

🐳 Add GitHub CLI to Dockerfile#4
rickyheijnen merged 1 commit intomainfrom
feat/add-gh-cli

Conversation

@rickyheijnen
Copy link
Copy Markdown
Member

🔍 Samenvatting

Deze PR voegt GitHub CLI (gh) toe aan de Dockerfile van onze GitHub runners

📝 Beschrijving

  • Installeer package gh in de Docker image

✅ Checklist

  • Code is lokaal getest
  • Tests zijn toegevoegd/aangepast
  • Documentatie bijgewerkt (indien nodig)

@rickyheijnen rickyheijnen self-assigned this Aug 14, 2025
@rickyheijnen rickyheijnen requested a review from LegeBeker August 14, 2025 06:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 14, 2025

Walkthrough

Added the GitHub CLI (gh) to the list of packages installed in the Dockerfile's apt install step; the apt update/install sequence and cleanup commands were not changed.

Changes

Cohort / File(s) Summary of changes
Docker base image dependencies
Dockerfile
Added gh (GitHub CLI) to the apt install package list; no other build steps, commands, or cleanup altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5016c and bb5e549.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-gh-cli

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (3)
Dockerfile (3)

25-25: Add a quick install verification to fail fast if gh is unavailable.

Appending a version check ensures the layer fails early if the package isn’t resolvable.

-    yamllint \
- && apt clean \
+    yamllint \
+ && gh --version >/dev/null \
+ && apt clean \

1-1: Consider pinning the base image tag for reproducible builds.

Using :latest can introduce breaking changes unexpectedly. Prefer a specific version or digest of ghcr.io/actions/actions-runner.


25-25: Optional: Pin gh to a known version or install from a release .deb for determinism.

If you prefer strict reproducibility, install a specific version from GitHub releases instead of tracking repo latest.

-    git-lfs \
-    gh \
+    git-lfs \
+    # keep gh omitted here if installing via .deb below \
     # Node.js (installed via nodesource script)
     nodejs \

Then add a separate step (outside the selected range) right after the APT block:

# Install a specific version of GitHub CLI (example version)
RUN GH_VERSION=2.53.0 \
 && wget -q https://github.com/cli/cli/releases/download/v${GH_VERSION}/gh_${GH_VERSION}_linux_amd64.deb \
 && apt install -y ./gh_${GH_VERSION}_linux_amd64.deb \
 && rm -f gh_${GH_VERSION}_linux_amd64.deb
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 839e602 and 0c5016c.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)

Comment thread Dockerfile
@rickyheijnen rickyheijnen merged commit bc64129 into main Aug 15, 2025
3 checks passed
@rickyheijnen rickyheijnen deleted the feat/add-gh-cli branch August 15, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants