🐳 Add GitHub CLI to Dockerfile#4
Conversation
WalkthroughAdded the GitHub CLI ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
Dockerfile (3)
25-25: Add a quick install verification to fail fast if gh is unavailable.Appending a version check ensures the layer fails early if the package isn’t resolvable.
- yamllint \ - && apt clean \ + yamllint \ + && gh --version >/dev/null \ + && apt clean \
1-1: Consider pinning the base image tag for reproducible builds.Using
:latestcan introduce breaking changes unexpectedly. Prefer a specific version or digest ofghcr.io/actions/actions-runner.
25-25: Optional: Pin gh to a known version or install from a release .deb for determinism.If you prefer strict reproducibility, install a specific version from GitHub releases instead of tracking repo latest.
- git-lfs \ - gh \ + git-lfs \ + # keep gh omitted here if installing via .deb below \ # Node.js (installed via nodesource script) nodejs \Then add a separate step (outside the selected range) right after the APT block:
# Install a specific version of GitHub CLI (example version) RUN GH_VERSION=2.53.0 \ && wget -q https://github.com/cli/cli/releases/download/v${GH_VERSION}/gh_${GH_VERSION}_linux_amd64.deb \ && apt install -y ./gh_${GH_VERSION}_linux_amd64.deb \ && rm -f gh_${GH_VERSION}_linux_amd64.deb
0c5016c to
7eba314
Compare
7eba314 to
bb5e549
Compare
🔍 Samenvatting
Deze PR voegt GitHub CLI (
gh) toe aan de Dockerfile van onze GitHub runners📝 Beschrijving
ghin de Docker image✅ Checklist