fix(observability): inject TRA support-file listener synchronously (SDK-7121)

[osho-20]

Summary

The new Automate dashboard (TRA / Test Observability) received no test events for Cypress runs on a customer's DEV pipeline, while the old Automate dashboard worked and the same suite/CLI/packages worked on another environment. Ref: SDK-7121.

Root cause

setEventListeners (bin/testObservability/helper/helper.js) injects the observability plugin into the user's Cypress support file:

require('browserstack-cypress-cli/bin/testObservability/cypress');

It did this inside an async glob(pattern, {}, cb) callback and returned immediately without awaiting it. In bin/commands/runs.js, the caller proceeds synchronously to md5 hashing (checkUploadedMd5) and zip archiving (archiver.archive) right after the call. So the injection raced the archive:

• Race won (fast FS / UAT): instrumented suite is zipped → TRA works.
• Race lost (slower CI / customer DEV): the archive reads the un-instrumented support file → remote runner has no o11y plugin → zero TRA events.

Md5 caching makes a lost race sticky: once a non-instrumented zip is cached under the original-content md5, every subsequent run logs "Skipping zip upload since BrowserStack already has your test suite..." and reuses the bad zip. The old Automate dashboard is unaffected because it does not depend on the injected plugin — exactly the reported asymmetry.

Reproduction

Calling setEventListeners and reading the support file synchronously afterwards (as md5/archive do):

before fix:  injected SYNCHRONOUSLY? false   (archive can ship un-instrumented suite)
after  fix:  injected SYNCHRONOUSLY? true

Fix

• setEventListeners → use glob.sync so the support-file writes complete before the function returns.
• Applied the same fix to the identical race in setAccessibilityEventListeners' glob-pattern branch (bin/accessibility-automation/helper.js).

Testing

• New regression test test/unit/bin/testObservability/setEventListeners.js — asserts the observability require is present synchronously after the call. Fails on unfixed code, passes with the fix.
• Existing accessibility-automation/cypress unit tests: green (6/6).
• commands/runs.js unit file shows the same pre-existing standalone failures with and without this change (unrelated setUsageReportingFlag assertions).

Release

• patch — bug fix
• Release note: Fix Cypress Test Observability (new Automate dashboard) receiving no test events on some CI pipelines due to a race between support-file instrumentation and test-suite archiving/caching.

🤖 Generated with Claude Code

[osho-20]

⚠️ Needs human review

File	Status	Reason
bin/accessibility-automation/helper.js	✅ All Clear	Covered by all lenses, no issues found
bin/testObservability/helper/helper.js	✅ All Clear	Covered by all lenses, no issues found
test/unit/bin/testObservability/setEventListeners.js	🔴 Author to Fix 1	1 ungrounded test-isolation finding — verify independently

↻ This verdict comment is the review anchor — it's updated in place on each run (the gate posts its status separately).

— SDK PR Review Agent