use options class instead deprecated DesiredCapabilities#24
use options class instead deprecated DesiredCapabilities#24avinash-bharti wants to merge 3 commits intomasterfrom
Conversation
| throws MalformedURLException, InterruptedException { | ||
| DesiredCapabilities caps = new DesiredCapabilities(); | ||
| throws MalformedURLException, InterruptedException { | ||
| UiAutomator2Options options = new UiAutomator2Options(); |
There was a problem hiding this comment.
Please use Mutuable Caps?
There was a problem hiding this comment.
This has been discussed with product team and @francisf and we decided to use Options.
Mutuable caps are not needed here, for android and ios separate folders are present because a single script cannot be used for both ios and android automation.
| throws MalformedURLException, InterruptedException { | ||
| DesiredCapabilities caps = new DesiredCapabilities(); | ||
| throws MalformedURLException, InterruptedException { | ||
| XCUITestOptions options = new XCUITestOptions(); |
There was a problem hiding this comment.
Please use Mutuable Caps?
| caps.setCapability("platformVersion", "9.0"); | ||
| options.setCapability("deviceName", "Google Pixel 3"); | ||
| options.setCapability("platformName", "android"); | ||
| options.setCapability("platformVersion", "9.0"); |
There was a problem hiding this comment.
This is non-w3c compliant and it must go inside bStackOptions ?
https://www.w3.org/TR/webdriver1/#capabilities
There was a problem hiding this comment.
Also app cap is not complaint.
There was a problem hiding this comment.
For Appium these caps are general capabilities and not specific to Browserstack, please ref here
| capabilities.setCapability("platformName", "android"); | ||
| capabilities.setCapability("platformVersion", "9.0"); | ||
| options.setCapability("deviceName", "Google Pixel 3"); | ||
| options.setCapability("platformName", "android"); |
There was a problem hiding this comment.
Above comment applies here too.
|
Folder structure and readme suggestions: Option 1: Let's rename folders to: Option 2: |
|
Please close this pr as we are doing it as part of #25 |
3 participants
JIRA: https://browserstack.atlassian.net/browse/ASI-4226
This PR: