feat: missing-null-guard prior + more artifact patterns + docs#500
Merged
justn-hyeok merged 1 commit intomainfrom Apr 21, 2026
Merged
feat: missing-null-guard prior + more artifact patterns + docs#500justn-hyeok merged 1 commit intomainfrom
justn-hyeok merged 1 commit intomainfrom
Conversation
Three small follow-ups bundled to keep self-review cost to one cycle. A. Finding-class priors: new `missing-null-guard` class Observed on PR #499's own self-review as an FP (claimed missing guard on a value that's already guarded at function entry). Adds 4 patterns covering "missing null check", "no null guard", "null/undefined check", "undefined reference". Multiplier 0.7 — same as missing-validation, same structural FP shape. 3 new tests. C. Chunker: more BUILT_IN_ARTIFACT_PATTERNS Python (*.pyc, __pycache__, *.whl, egg-info), Go (vendor/), Rust (target/debug, target/release), Java (*.class, *.jar, *.war), Ruby (.bundle/), plus *.avif, *.bz2, *.wasm binary assets. 14 new pattern-match tests. E. Docs: HALLUCINATION_FILTER_DESIGN.md Original doc still described the 3-check Layer-1 design from #428. Replaced the check list with the current 7-check set (from #428, #462, #468 main, #499), documented the FINDING_CLASS_PRIORS table and witness-based echo dampener for discoverability. Tests: 3425 → 3442 (+17). Typecheck clean.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ CodeAgora: ACCEPT
no issues | 5 reviewers
There were no reported findings, no discussions, and no unresolved or escalated issues, so there is no evidence of defects to block the change; based on the available review record, the change appears safe to merge.
CodeAgora · Session: 2026-04-20/001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle of three small follow-ups from today's session. Single PR to keep self-review cost to one cycle.
A. Finding-class priors: new `missing-null-guard` class
Observed on PR #499's own self-review as an FP — reviewer claimed `activeReviewers` lacked a null guard while the actual code has one at function entry (line 31). Four patterns cover:
Multiplier 0.7, same as missing-validation (same structural FP shape). 3 new tests.
C. Chunker: more `BUILT_IN_ARTIFACT_PATTERNS`
Rounding out the #498 expansion with ecosystem-specific generated artifacts:
14 new pattern-match tests.
E. Docs: HALLUCINATION_FILTER_DESIGN.md
The original doc described the 3-check Layer-1 design from #428. Now 7 checks exist (added #462, #468 main, #499). Replaced the check list with the current set and documented the `FINDING_CLASS_PRIORS` tuning point + witness-based echo dampener so future contributors can find them.
Test plan