fix(ci): allow coverage for example-only package - #318
Merged
Conversation
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
July 24, 2026 23:31
|
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bsv/wallet-toolbox-examplescoverage behavior with its existing normal test behaviorRoot cause
Post-merge
mainrun 30133203726 passed the full workspace build/lint/test matrix plus SDK, DID, Wallet Toolbox, and VeriFast coverage, then failed when the generic coverage filter selected this example-only package. Its normaltestscript already uses--passWithNoTests;test:coveragedid not.Validation
The exact formerly failing filtered
pnpm -r ... run test:coveragecommand now exits 0, builds the package, and reports no tests without masking failures in packages that do have tests.No published runtime code, version, or release output changes.